Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade workflow-scm-step past 2.6 #86

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Conversation

basil
Copy link
Member

@basil basil commented Aug 2, 2019

Problem

Observed in jenkinsci/bom#53 when attempting to add workflow-multibranch to the managed set. Running the Plugin Compatibility Tester against workflow-multibranch plugin and a newer version of workflow-scm-step, the following error appears:

Failed to execute goal on project workflow-multibranch: Could not resolve dependencies for project org.jenkins-ci.plugins.workflow:workflow-multibranch:hpi:2.21: Could not find artifact org.jenkins-ci.plugins.workflow:workflow-scm-step:jar:tests:2.9 in repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/) -> [Help 1]

Evaluation

I saw that between workflow-scm-step 2.6 and 2.7 a tests-classified JAR was removed, yet workflow-multibranch still depends on it.

Solution

workflow-scm-step-2.6-tests.jar contains nothing other than the SCMStepTest class, and workflow-multibranch doesn't reference that class. The solution then is to remove the dependency on workflow-scm-step-2.6-tests.jar from workflow-multibranch, allowing us to bump workflow-scm-step past 2.6 from workflow-multibranch's POM.

Implementation

In this change I bump workflow-scm-step from 2.6 to 2.7 in workflow-multibranch's POM to cross this flag day.

@basil
Copy link
Member Author

basil commented Sep 16, 2019

@rsandell Gentle ping. No rush on this, but just wanted to make sure the first notification didn't slip by.

@dwnusbaum
Copy link
Member

Thanks!

@dwnusbaum dwnusbaum merged commit dc12464 into jenkinsci:master Dec 16, 2019
@basil basil deleted the scm-step branch November 23, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants